Introduced -Xswiftc -Xfrontend flag to GA workflow.#104
Merged
glbrntt merged 5 commits intoapple:mainfrom Jun 20, 2025
Merged
Conversation
glbrntt
requested changes
Jun 19, 2025
Comment on lines
+15
to
+18
| linux_6_0_arguments_override: "-Xswiftc -warnings-as-errors -Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable --explicit-target-dependency-import-check error" | ||
| linux_6_1_arguments_override: "-Xswiftc -warnings-as-errors -Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable --explicit-target-dependency-import-check error" | ||
| linux_nightly_next_arguments_override: "-Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable --explicit-target-dependency-import-check error" | ||
| linux_nightly_main_arguments_override: "-Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable --explicit-target-dependency-import-check error" |
Contributor
There was a problem hiding this comment.
This isn't going to work; SwiftPM generates some public types in the test targets which don't have Sendable annotations.
The CI passes at the moment because these changes haven't been picked up yet. From the logs:
docker run -v /home/runner/work/swift-http-structured-headers/swift-http-structured-headers:"$workspace" \
-w "$workspace" \
-e CI="$CI" \
-e GITHUB_ACTIONS="$GITHUB_ACTIONS" \
-e SWIFT_VERSION="6.0" \
-e setup_command_expression="$setup_command_expression" \
-e workspace="$workspace" \
swift:6.0-jammy \
bash -c "$setup_command_expression swift test -Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
Contributor
Author
There was a problem hiding this comment.
I'll add the flags to macOS CI only then.
glbrntt
reviewed
Jun 19, 2025
| xcode_16_1_build_arguments_override: "-Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" | ||
| xcode_16_2_build_arguments_override: "-Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" | ||
| xcode_16_3_build_arguments_override: "-Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" | ||
| xcode_26_beta_1_build_arguments_override: "-Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" |
Contributor
There was a problem hiding this comment.
I don't know if it's worth adding this one: the beta will change at some point and we'll have to keep updating the args.
Contributor
Author
There was a problem hiding this comment.
Okay, I've removed it.
Co-authored-by: George Barnett <gbarnett@apple.com>
glbrntt
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced -Xswiftc -Xfrontend flag to GA workflow. There were no Sendability warnings to fix after this change.