Skip to content

Fix typo in ASN1ObjectIdentifier BER initializer parameter name.#120

Merged
Lukasa merged 1 commit intoapple:mainfrom
lamtrinhdev:Fix_param_incorrect_Name_at_ObjectIdentifier.swift
Apr 16, 2026
Merged

Fix typo in ASN1ObjectIdentifier BER initializer parameter name.#120
Lukasa merged 1 commit intoapple:mainfrom
lamtrinhdev:Fix_param_incorrect_Name_at_ObjectIdentifier.swift

Conversation

@lamtrinhdev
Copy link
Copy Markdown
Contributor

Summary

Fix typo in the internal parameter name of ASN1ObjectIdentifier.berEncoded(withIdentifier:) initializer.

Changes

  • Rename parameter identiiferidentifier in ASN1ObjectIdentifier.berEncoded(withIdentifier:) (ObjectIdentifier.swift:133)

Impact

  • The typo only affected the internal parameter name (external label withIdentifier was correct)
  • No functional changes or breaking changes
  • Improves code readability and maintainability

Testing

  • Existing tests continue to pass
  • No behavioral changes

….berEncoded(withIdentifier:) for correctness.
Copy link
Copy Markdown
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@Lukasa Lukasa added the 🔨 semver/patch No public API change. label Apr 16, 2026
@Lukasa Lukasa enabled auto-merge (squash) April 16, 2026 19:58
@Lukasa Lukasa merged commit af3440c into apple:main Apr 16, 2026
56 checks passed
@simonjbeaumont simonjbeaumont added semver/none No version bump required. and removed 🔨 semver/patch No public API change. labels Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver/none No version bump required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants