Make Statement.setPagingSize method public#30
Open
virtan wants to merge 2 commits intoapple:mainfrom
Open
Conversation
glbrntt
reviewed
Jun 4, 2024
|
|
||
| func setPagingSize(_ pagingSize: Int32) throws { | ||
| /// Sets the paging size of the returned paginated results. | ||
| public func setPagingSize(_ pagingSize: Int32) throws { |
There was a problem hiding this comment.
Can we use Int instead here? It should be preferred for public APIs.
Author
|
There is a variant of |
That one should ideally be I'd much rather we course correct and add appropriate APIs rather than being consistent with past mistakes. |
017c634 to
d183c0e
Compare
glbrntt
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make Statement.setPagingSize method public
Motivation:
In some cases we may need to change paging size to reduce chances of read timeouts
Modifications:
The method setPagingSize() existed but wasn't public so was inaccessible for clients
Result:
With this change it would become public and let a client to set custom paging sizes on per statement basis