[Deque/HashTree] Remove references to ManagedBuffer.capacity and use the given minCapacity - #700
Merged
Merged
Conversation
Azoy
force-pushed
the
deque-malloc-size
branch
from
August 12, 2026 21:05
e3e0241 to
6f6c690
Compare
…city Fix errors Update Deque._UnsafeHandle.swift
Azoy
force-pushed
the
deque-malloc-size
branch
from
August 12, 2026 21:09
6f6c690 to
d6c0fe0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a
ManagedBufferobject, the factory closure passes the newly createdManagedBufferinstance for the caller to make the header with. ReferencingManagedBuffer.capacitywill end up making calls tomalloc_sizeto return the allocation size, but the caller has already supplied it with a minimumCapacity argument. For embedded, it's critical that we don't needlessly link against system symbols that may or may not exist especially since the information we need is already there (and in fact the code was already guarding against it for OpenBSD).Checklist