Update EnvironmentValueArrayDecoder to emit empty values when present #133
+57
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
What I found while working on the issue is that Swift’s native API is String.split(separator:), whereas components(separatedBy:) is an NSString-bridged method backed by UTF-16 storage. Swift’s String uses UTF-8-backed storage. The preferred API is split(separator:), with omittingEmptySubsequences when needed. In the project, CLIArgumentParser.swift:125 uses the NSString API. It would be worth converting this to String.split(separator:) and disallowing future use of NSString APIs. Due to bridging between the two types, it is easy to accidentally rely on NSString when working with String. If needed, I will revert the commit: ae5cf01 |
Adobels
changed the title
czechboy0
reviewed
Dec 23, 2025
| } | ||
|
|
||
| @available(Configuration 1.0, *) | ||
| @Test func valueForKeyOfIntArrayTypes() throws { |
Contributor
There was a problem hiding this comment.
Please add some success cases as well here for the ints and doubles
Adobels
force-pushed
the
add-support-for-empty-substrings-when-parsing-arrays-in-environement-variable-provider
branch
2 times, most recently
from
0757dc1 to
2116aa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #122
Modifications
omittingEmptySubsequencestofalseinString.split(separator:omittingEmptySubsequences:)when decoding a string that represents Bool, Int, or Double arrays separated by commas inEnvironmentValuesProvider.CLIArgumentParser.swift:125to usesplitinstead ofcomponents(separatedBy:), ensuring homogeneous usage of Swift’s splitting APIs.Result
A string representing an array of values separated by
","will now emit empty values when two separators appear together while parsingEnvironmentValuesProviderdictionaries.This results in treating an empty value as an empty string and, consequently, throwing an error when parsed by individual value decoders for Int, Double, and Bool.
The additional update enforces homogeneous API usage and favors Swift’s native
split(separator:)method.Test Plan
Add tests covering empty values in Int, Double, and Bool arrays.