[SLG-0004]: Revised Metadata value attributes as CustomStringConvertible#453
Draft
kukushechkin wants to merge 7 commits intoapple:mainfrom
Draft
[SLG-0004]: Revised Metadata value attributes as CustomStringConvertible#453kukushechkin wants to merge 7 commits intoapple:mainfrom
CustomStringConvertible#453kukushechkin wants to merge 7 commits intoapple:mainfrom
Conversation
2a25dbc to
aa366c5
Compare
f294301 to
9e7b525
Compare
weissi
reviewed
Apr 30, 2026
5500ff2 to
d87e798
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This is a revision of SLG-0004 previously discussed here. Note this is a draft, including more than just the proposal implementation.
Add an extensible per-value attribute mechanism for metadata.
This PR also includes examples:
OSLogHandlerusingSensitivityattribute withos_log.Motivation:
Metadata values in
swift-logare opaque strings by the time theLogHandlerreceives them. The call site oftenknows things about a value that the handler cannot infer — for example, whether the value should be redacted in
different environments.
Modifications:
AttributedStringCarrier: CustomStringConvertible-based mechanism toLogging.Sensitivityas an example attribute to the newLoggingAttributestarget.OSLogHandleras an example of a concrete log handler taking advantage of theSensitivityattribute.Result:
swift-logprovides an optional extensible mechanism for attaching attributes to metadata values.