Update responsiveness server#102
Closed
josephnoir wants to merge 6 commits intoapple:mainfrom
Closed
Conversation
Motivation: Build a basic implementation of the responsiveness server. It does not need HTTP/1 or TLS to begin with, just HTTP/2. It should also support a shutdown handler for automatic testing. Modifications: Rebuild the initial app to support just HTTP/2. Upgrade the responsiveness server to the new version, which supports a fallback handler to implement the shutdown endpoint. Integrate the ServerQuiescingHelper and connection management to properly shutdown the server. Result: The new server only supports HTTP/2 and can be shut down gracefully.
Lukasa
reviewed
Jun 27, 2025
Contributor
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
It seems a bit unnecessary to make this only support HTTP/2: what's the motivation for that change?
Contributor
Author
|
Sorry, there was a misunderstanding. I'll close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuild http/2 responsiveness server app
Motivation
Build a basic implementation of the responsiveness server. It does not
need HTTP/1 or TLS to begin with, just HTTP/2. It should also support a
shutdown handler for automatic testing.
Modifications
Rebuild the initial app to support just HTTP/2. Upgrade the
responsiveness server to the new version, which supports a fallback
handler to implement the shutdown endpoint. Integrate the
ServerQuiescingHelper and connection management to properly shutdown the
server.
Adopt code from grpc-swift-nio-transport to handle graceful shutdown of HTTP2 connections, specifically:
Add
NOTICE.txtfile to reference the original code.Result
The new server only supports HTTP/2 and can be shut down gracefully.