chore: stop naming client projects in a public repository - #114
Merged
Merged
Conversation
Two places named internal client projects. The publishing-check comment was the worse of them: it named two of them and disclosed which toolbox modules each app depends on, which is more than the comment needed to make its point. Generalised to "one consumer" and "another" — the reasoning about why a green consumer proved nothing is what mattered, not which apps they were. The Nav3Navigation credit keeps the thanks and drops the project name. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The AuthApi KDoc published a working email and password pair — a real corporate address alongside `secret123` — for a live Forge-hosted backend. The host now returns 522 (Cloudflare up, origin gone), so it appears decommissioned, but the pairing should not have been committed regardless: an email and password published together are what credential-stuffing lists are built from, and that risk attaches to the address rather than to the server. Scrubbing the file does not undo it — git history keeps both values — so treat them as harvested and rotate the password anywhere it was reused. Also notes at BASE_URL that the host is gone, so the next person to try the network-backed parts of the demo learns it from the source rather than from a timeout. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to removing a client name from the 1.9.0 release notes — the same thing was in the tree.
publishing-check/build.gradle.ktsnamed two client apps and disclosed which toolbox modules each depends on. That is more than the comment needed to make its point. The reasoning — why a green consumer proved nothing about the 1.8.2 regression — is fully preserved; only the identities are gone.Nav3Navigation/README.mdcredited a named client team. Thanks kept, name dropped.Two matches in the sweep were false positives and are untouched: "accelerate" as a verb in the root README, and
progressReportermatching "Porter".🤖 Generated with Claude Code