Add desktop full screen toggle, defaulting to full screen - #130
Open
jdegeest wants to merge 1 commit into
Open
Conversation
jdegeest
force-pushed
the
fullscreen-toggle
branch
from
August 28, 2026 21:57
b54be38 to
7a5654a
Compare
Applies the saved preference at startup. New FullScreen utility owns the window state, exposing a ValueNotifier the button listens to, so the map screen holds no local state of its own. Constants.supportsWindowManagement gates it to linux/macos/windows, and AppSettings persists the choice under key-full-screen. Adds a dependency on window_manager, which declares linux/macos/windows only, so it is not registered on Android or iOS. USER_MANUAL.md updated in sections 2, 4.3 and 14. assets/docs/USER_MANUAL.pdf is not regenerated here.
jdegeest
force-pushed
the
fullscreen-toggle
branch
from
August 28, 2026 22:02
7a5654a to
7a80688
Compare
jdegeest
marked this pull request as ready for review
August 28, 2026 22:04
Author
|
Verified on Linux, needs verification on OSX/Windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting up AvareX on a Microsoft Surface running Ubuntu/GNOME, I found no way to run the app full screen. This PR adds a toggle button to the map screen for window-managed desktop environments.
The button is gated to Linux, macOS and Windows via
Constants.supportsWindowManagement. The choice is persisted underkey-full-screenand reapplied at startup, defaulting to on, since the window chrome is wasted space when the app is used as an EFB.Window handling lives in a new
lib/utils/full_screen.dart, which owns the state and exposes aValueNotifierthe button listens to, so the map screen holds no local state of its own.This introduces a dependency on
window_manager. It declareslinux/macos/windowsonly, so it is not registered on Android or iOS, and no mobile plugin registrant is touched by this change.USER_MANUAL.mdis updated in sections 2 (platform availability), 4.3 (map controls) and 14 (path index). I have not regeneratedassets/docs/USER_MANUAL.pdf— the regeneration script is macOS-specific and I am on Linux, so the output would differ from your toolchain.