-
Notifications
You must be signed in to change notification settings - Fork 212
Fix deployments stuck in ‘Finalizing’ status for Functions #2818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Console (appwrite/console)Project ID: Tip Sites auto-generate unique domains with the pattern https://randomstring.appwrite.network |
WalkthroughThree Svelte components were updated to normalize status rendering. Each adds a derived Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@src/routes/`(console)/project-[region]-[project]/functions/function-[function]/(components)/deploymentCard.svelte:
- Line 42: displayStatus is being inferred as string but the Status component
expects a specific union type; update the assignment to assert the correct union
type (e.g., cast the value to the shared Status type) so it matches the Status
component prop. Locate the displayStatus declaration and change the expression
to include a type assertion (or import and use the shared
DeploymentStatus/Status type) for the derived value so the type-checker accepts
passing displayStatus into the Status component.
🧹 Nitpick comments (1)
src/routes/(console)/project-[region]-[project]/functions/function-[function]/deployment-[deployment]/+page.svelte (1)
46-46: Consider adding type assertion for consistency.While this file doesn't have a type error (since both consumers accept
string), consider adding the same type assertion as suggested fordeploymentCard.svelteto maintain consistency across the codebase and prevent future issues ifdisplayStatusis used elsewhere.
.../project-[region]-[project]/functions/function-[function]/(components)/deploymentCard.svelte
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const should be fine for all $deriveds 👍 .

What does this PR do?
Before:
After:
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.