-
Notifications
You must be signed in to change notification settings - Fork 300
Update timeout information in functions documentation #2726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Clarify timeout limits for asynchronous and synchronous functions.
WalkthroughThis pull request updates the Functions documentation Timeout section to distinguish async and sync function timeouts: a system-wide maximum of 900 seconds (15 minutes) for asynchronous functions and a hard 30-second limit for synchronous functions. It corrects "system wide" to "system-wide" and includes a small trailing-newline formatting tweak. Changes: +3/-2 lines. No code or exported/public signatures were modified. Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Clarifies function timeout limits by distinguishing between asynchronous and synchronous execution constraints in the Functions documentation.
Changes:
- Update the Timeout section to specify the 900s maximum for asynchronous functions.
- Add the 30s hard limit for synchronous functions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/routes/docs/products/functions/functions/`+page.markdoc:
- Around line 165-168: Update the wording in the "## Timeout {% `#timeout` %}"
section so units are consistent: change the phrase "For synchronous functions,
there is a hard limit of 30s." to use the full word "seconds" (i.e., "30
seconds") to match "900 seconds" used earlier; edit the sentence containing
"hard limit of 30s" in the +page.markdoc section to read "hard limit of 30
seconds."
Clarify the different timeout limits for asynchronous and synchronous functions.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.