perf: shared-vertex projection, run-wise colour validation and a bounded stroke walk - #46
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three render-path optimisations. Every cell byte-identical, checked against all three fidelity digests.
Bounded stroke walk —
applyCellHook6.19 → 3.35 ms,base-raster−16.8%. The stamper walked 1.1M cells per render, 99.5% of them off-grid: a road that leaves and re-enters the viewport is one segment thousands of cells long. It now iterates only the reachable range. Same samples, same output.Colour validated once per run, not per cell — spans −45%, atlas −60%. Grids average 17 cells per colour run and the regex ran on every one.
Shared vertices projected once — 259,200 vertex occurrences over 65,341 unique positions on a real terrain tile. Orbit at 283×105 −4%, terrain-only walk −11.3%. Roughly nothing for buildings, whose walls share only vertical edges.
Also:
bench/maps-render --walk-lookdefaulted to 0.15°/frame, which renders synchronously and inflated every walk number that harness produced. Now0; affected figures re-derived.Two defects found, reported in
docs/design/performance.md, not fixed here — neither is byte-identical:hiddenskip, so it claims cells for hidden polygons and blanks layers that paint there.