Support lightweight query statistics modes - #87
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept
--query-mode=WITH_STATSandWITH_PLAN_AND_STATSto request overall execution statistics without operator-level profiling. The latter also includes a query plan. Both modes execute queries and require parameter values; PLAN retains its existing support for bare parameter types.Reject both modes with Partitioned DML before client creation because that SDK path ignores query mode. The regression matrix verifies that rejected invocations leave data unchanged. Local gRPC tests capture the query mode and verify rows/statistics across JSON/YAML eager and lazy output. README help and mode semantics are updated.
Validation:
go test ./...(including the emulator no-write matrix),go build ./...,golangci-lint run --timeout=5m(0 issues),git diff --check, and generated CLI help comparison with Go 1.25.13. Local transport tests verify request and output wiring; production optimizer statistics are not live-probed.