Refactor transport tests to inspect outgoing RPCs - #89
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transport tests previously repeated Spanner fake servers to verify outgoing options and plan/stat output combinations. Inspect role, priority, and query mode through shared client interceptors instead, using the emulator for session and transaction setup.
Move arbitrary plan/stat combinations to unit tests and retain two fake-server smoke cases for the eager and lazy SDK-to-output paths. Add an internal client-option injection point without changing CLI behavior. The migrated request tests now require Docker, like the existing emulator integration suite.
Validation: Go 1.25.13 full test suite with Colima, build, and golangci-lint passed. Interceptor tests cover rejection before sending and preserving the server status after a send returns EOF.