Conversation
google.golang.org/grpc v1.81.1 had two reachable vulnerabilities fixed in v1.83.1; pin v1.83.2. golang.org/x/text moves to v0.41.0 with that grpc requirement (above the GO-2026-5970 floor). spanemuboost v0.4.7 picks up the newer emulator image. golang.org/x/term also moves to v0.45.0 from the same go get.
Symlinked parent directories of not-yet-created files compared unequal, so --output and --plan-output could publish onto the same path. Directories and other non-regular targets were only rejected at rename, after DML had committed. Resolve the deepest existing ancestor before comparing paths or creating temps, reject non-regular destinations up front, and map /dev/null in-process like /dev/stdout. SIGTERM now runs the same sink abort path as SIGINT. Published files keep mode 0600. Errors no longer dump usage or a log timestamp; --version and distinct exit codes cover parse vs post-commit output failure. stripLeadingComments is removed in favor of the memefish DML lexer. jqresult.Compile no longer takes an unused input mode.
ResultSetMapFromRowIterator had no callers. RowIter.Prime, Next, and Drain were exported wrappers around unexported methods that only Lazy uses. NeedsGraphviz now selects the SVG/PNG renderer path instead of sitting unused beside a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden output destinations and CLI process lifecycle after a local codebase review.
--output/--plan-outputcollisions when the parent directory is a symlink and the target does not exist yet. Temp files are created in the resolved directory./dev/nullis mapped in-process like/dev/stdoutand/dev/stderr.SIGTERMwith the same sink abort path asSIGINT, so cancelled runs do not leave.execspansql-*.tmpfiles.0600(including replacements). README documents this as intentional for possibly sensitive rows.--versionis wired through GoReleaser ldflags. Exit2is usage/parse; exit3is output failure after a committed statement.jqresulthelpers and the unusedCompileinput-mode argument.google.golang.org/grpcto v1.83.2,golang.org/x/textto v0.41.0, andgithub.com/apstndb/spanemuboostto v0.4.7.Behavior changes
0600./dev/nulldestinations are allowed (unlike two stdout destinations).1now see2or3for usage errors and post-commit output failures.Tests run
go vet ./...GOTOOLCHAIN=go1.25.13 golangci-lint run ./...go test ./params/... ./jqresult/... ./resultset/... ./internal/...DOCKER_HOST=unix://$HOME/.colima/default/docker.sock TESTCONTAINERS_DOCKER_SOCKET_OVERRIDE=/var/run/docker.sock go test ./...go run golang.org/x/vuln/cmd/govulncheck@v1.8.0 ./...