Skip to content

Raise test coverage to 85% while retaining the 80% CI floor #941

Description

@apstndb

Goal

Raise the existing full-suite statement coverage to at least 85% on main, while retaining the CI acceptance floor at 80%. The previous main CI result was 80.6%.

Scope

Add meaningful regression tests in small, independently reviewable PRs. Start with uncovered completion logic, offline feature behavior, and statement/execution paths. Prefer existing fixtures and in-process transports. Minimal production test seams require a concrete justification.

Do not change .octocov.yml, coverage exclusions, generated-file filtering, the measurement command, dependencies, or unrelated production behavior. Do not inflate coverage with assertion-free calls or broad refactoring.

Acceptance

  • make test-coverage and go tool cover -func=tmp/coverage.out report at least 85% on the integrated source; verify the main CI result too.
  • .octocov.yml continues to specify acceptable: 80%.
  • Each PR passes make check, relevant focused race checks, current-head review, and all CI checks.
  • Tests assert outputs, state changes, request parameters, and error contracts as appropriate; they do not introduce network/credential dependencies into offline tests.
  • Preserve existing test isolation, especially global logger/configuration state.

Use Refs in implementation PRs until the combined result is verified. Record final coverage evidence before closing through the final PR.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions