Conversation
Drop the local FLOAT32 plugin now that upstream #268 emits CAST(-0.0 AS FLOAT32). SQL export and typed replay call LiteralFormatConfig directly. Keep application selection tests and leave the scalar/array/struct matrix to spanvalue.
Code Metrics Report📊 View detailed coverage report (available for 7 days)
Details | | main (1b8003f) | #1018 (93db072) | +/- |
|---------------------|----------------|-----------------|-------|
- | Coverage | 87.2% | 87.2% | -0.1% |
| Files | 132 | 132 | 0 |
| Lines | 13284 | 13277 | -7 |
- | Covered | 11588 | 11580 | -8 |
+ | Code to Test Ratio | 1:2.5 | 1:2.5 | +0.0 |
| Code | 28876 | 28861 | -15 |
- | Test | 73544 | 73521 | -23 |
- | Test Execution Time | 2m39s | 3m4s | +25s |Code coverage of files in pull request scope (92.5% → 92.2%, patch 100.0%)
Reported by octocov |
Owner
Author
|
Reviewed f0a66f5: no actionable findings. The direct preset calls preserve SQL export, typed replay and cyclic DUMP policy; upstream-owned literal cases and retained application integration assertions were checked. Independent |
apstndb
marked this pull request as ready for review
September 15, 2026 19:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopt released
spanvalue v0.9.0and remove the local FLOAT32 negative-zero formatting workaround. SQL export, typed replay and cyclic DUMP now use the library's literal preset directly; cyclic DUMP retains its additional wire-validation checks.The upstream fix in apstndb/spanvalue#268 emits
CAST(-0.0 AS FLOAT32)so replay preserves the sign. Its scalar/array/struct and SQL INSERT matrices are covered byTestLiteralFloat32NegativeZeroandTestSQLInsertWriterFloat32NegativeZeroupstream. The application keeps independent expected literals for formatter selection, all SQL INSERT modes, matching string/JSON text, and empty/NULL arrays. Malformed FLOAT32 checks require the error cause and payload, and real buffered/streamed DUMP replay still checks sign bits.Validation: Go 1.26.8
make checkwith golangci-lint 2.13.2,make check-race, focused SQL-literal/DUMP replay tests, and all required CI checks. The dependency's Go 1.25 minimum is below the application's existing Go 1.26.8 requirement.Physical line changes: production -21, tests -18, fixtures unchanged. No
replacedirective or unrelated dependency upgrades.