Skip to content

Enter DDL wait loop before canceling RPC test #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
apstndb wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Enter DDL wait loop before canceling RPC test #947

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
97f6716
Test DDL execution and EXPLAIN/DESCRIBE statement paths
cursoragent Sep 12, 2026
cb04d22
Merge origin/main into coverage-941-statement-execution after #942
cursoragent Sep 12, 2026
ac976b7
Fix DDL RPC tests for Codex review findings
cursoragent Sep 12, 2026
c458db2
Enter the DDL wait loop before canceling the test
cursoragent Sep 12, 2026
015d283
Merge origin/main into coverage-941-statement-execution after #943
cursoragent Sep 12, 2026
bb0ce44
Merge origin/main into coverage-941-statement-execution after #945
cursoragent Sep 12, 2026
27ba1b6
Merge origin/main into coverage-941-statement-execution after #944
cursoragent Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions internal/mycli/execute_ddl_rpc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,14 @@ func TestExecuteDdlStatementsRPC(t *testing.T) {

waitForClosed(t, guard, server.accepted, "accepted UpdateDatabaseDdl")
waitForClosed(t, guard, server.polled, "first GetOperation poll")
// The fake has served GetOperation. Wait until executeDdlStatements has
// left op.Poll and blocked in the wait-loop select before canceling.
// This is not a production deadline; cancel remains explicit.
select {
case err := <-errc:
t.Fatalf("executeDdlStatements returned before wait-loop cancel: %v", err)
case <-time.After(100 * time.Millisecond):
}
cancel()

var err error
Expand Down