Give receivers and transmitters their own index of refraction#214
Merged
marcomuzio merged 1 commit intomasterfrom Feb 18, 2026
Merged
Give receivers and transmitters their own index of refraction#214marcomuzio merged 1 commit intomasterfrom
marcomuzio merged 1 commit intomasterfrom
Conversation
abigailbishop
approved these changes
Feb 18, 2026
Member
abigailbishop
left a comment
abigailbishop
left a comment
There was a problem hiding this comment.
Looks okay to me but I'm not the most familiar with what you did
clark2668
reviewed
Feb 18, 2026
Collaborator
|
Okay, lgtm. |
AlanSalcedo
approved these changes
Feb 18, 2026
Member
AlanSalcedo
left a comment
AlanSalcedo
left a comment
There was a problem hiding this comment.
Looks good. Just one question.
Contributor
Author
|
Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gives transmitter and receiver antennas their own indexes of refraction, but still assumes all receivers/transmitters share the same index. This also adds some sanity checks to make sure thats true, but only for receivers since the code currently only supports a single transmitter type at a time.
Testing summary
A3 veff test: passed ✅
birefringence veff test: passed ✅
pa veff test: passed ✅
pulser veff test: passed ✅