Skip to content

Feat/add support bnb#148

Merged
brickpop merged 3 commits intomainfrom
feat/add-support-bnb
Mar 26, 2025
Merged

Feat/add support bnb#148
brickpop merged 3 commits intomainfrom
feat/add-support-bnb

Conversation

@Rekard0
Copy link
Copy Markdown
Contributor

@Rekard0 Rekard0 commented Mar 18, 2025

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task ID: OS-?

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I created tasks to update dependent repositories (OSx, Plugins)
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.

Copy link
Copy Markdown
Contributor Author

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reference OSx branch/PR from which this deployment is made: aragon/osx#651

Comment thread configs/src/deployments/json/bscMainnet.json Outdated
brickpop
brickpop previously approved these changes Mar 26, 2025
Copy link
Copy Markdown
Contributor

@brickpop brickpop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test suite seems to be failing, please ensure that any relevant changes are in place

@brickpop brickpop force-pushed the feat/add-support-bnb branch from 1d67448 to 330f7f8 Compare March 26, 2025 15:58
@brickpop brickpop merged commit 74a4720 into main Mar 26, 2025
5 checks passed
@brickpop brickpop deleted the feat/add-support-bnb branch March 26, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants