Skip to content

Chore: correct the ERC on the DAO docs page #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wildmolasses wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Chore: correct the ERC on the DAO docs page #667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/contracts/docs/modules/ROOT/pages/core/dao.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ Currently, Externally Owned Accounts (EOAs) can sign messages with their associa
An exemplary use case is a decentralized exchange with an off-chain order book, where buy/sell orders are signed messages.
To accept such a request, both, the external service provider and caller need to follow a standard with which the signed message of the caller can be validated.

By supporting the link:https://eips.ethereum.org/EIPS/eip-721[ERC-721 (NFT Standard)], your DAO can validate signatures via its `isValidSignature` function that forwards the call to a signature validator contract.
By supporting the link:https://eips.ethereum.org/EIPS/eip-1271[ERC-1271 (Standard Signature Validation Method for Contracts)], your DAO can validate signatures via its `isValidSignature` function that forwards the call to a signature validator contract.

=== 6. Permission Management

Lastly, it is essential that only the right entities (e.g., the DAO itself or trusted addresses) have permission to use the above-mentioned functionalities. This is why Aragon OSx DAOs contain a flexible and battle-tested **Permission Manager** being able to assign permissions for the above functionalities to specific addresses.
Although possible, the permissions to execute arbitrary actions or upgrade the DAO should not be given to EOAs as this poses a security risk to the organization if the account is compromised or acts adversarial. Instead, the permissions for the above-mentioned functionalities are better restricted to the `DAO` contract itself and triggered through governance xref:core/plugins.adoc[plugins] that you can install on your DAO.

To learn more about permissions and how they work in detail, check out the xref:core/permissions.adoc[Permission Manager] section.
To learn more about permissions and how they work in detail, check out the xref:core/permissions.adoc[Permission Manager] section.
Loading