Make import.sh more robust supporting more environments#9
Open
kjpopov wants to merge 2 commits intoarangodb:masterfrom
Open
Make import.sh more robust supporting more environments#9kjpopov wants to merge 2 commits intoarangodb:masterfrom
kjpopov wants to merge 2 commits intoarangodb:masterfrom
Conversation
|
Hi @kjpopov Many thanks for contributing. We are obliged by law to have a signed scanned copy of a Contributor License Agreement (CLA) to be able to accept pull requests to the official ArangoDB repository We use an Apache 2 CLA for ArangoDB and its companion projects, which can be found here: https://www.arangodb.com/documents/cla.pdf Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change proposal I am making import.sh more flexible to support more environments and arangosh parameters to be configurable not hardcoded to -s.
Running the current master version results to an error message probably because of an obsoleted option -s
This proposed solution is tested and works well for me with arangodb v3.4.7 osx Mojave 10.14.5
and arangodb installed via
brew install arangodb