[Feature] [Platform] Azure Storage Integration #2004

ajanikow · 2025-12-17T09:58:58Z

No description provided.

Copilot

Pull request overview

This pull request adds Azure Blob Storage integration to the platform storage system, extending the existing storage backend capabilities that currently support S3 and GCS. The implementation provides a complete Azure storage backend with authentication via Azure service principals, blob operations (read, write, list, delete), and Kubernetes integration.

Key Changes

Adds Azure Blob Storage as a third storage backend option alongside S3 and GCS
Implements Azure authentication using client secret credentials with support for both direct values and file-based secrets
Provides complete blob storage operations including read, write, list, head, and delete with SHA256 checksums
Integrates with the existing Kubernetes CRD system and sidecar injection framework

Reviewed changes

Copilot reviewed 29 out of 30 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
pkg/util/azure/provider.go	Implements Azure authentication provider with client secret credential support
pkg/util/azure/config.go	Provides Azure configuration with endpoint resolution logic
pkg/util/tests/azure.go	Test helpers for Azure Blob Storage integration tests
pkg/util/env_t.go	Testing utility for requiring environment variables
pkg/util/refs.go	Adds Count utility function for validating backend selection
pkg/util/constants/constants.go	Defines secret key constants for Azure credentials
pkg/apis/platform/v1beta1/storage_spec_backend_abs.go	API definition for Azure Blob Storage backend specification
pkg/apis/platform/v1beta1/storage_spec_backend.go	Updates backend validation to support Azure alongside S3 and GCS
pkg/integrations/storage_v2.go	Registers Azure-specific CLI flags for storage integration
pkg/integrations/sidecar/integration.storage.v2.go	Implements sidecar environment variables and volume mounts for Azure
integrations/storage/v2/shared/abs/*.go	Complete implementation of Azure Blob Storage IO operations
integrations/storage/v2/configuration.go	Adds Azure configuration type to storage v2 system
integrations/storage/v2/object.go	Implements Kubernetes object-based Azure storage initialization
integrations/storage/v2/suite_azure_test.go	Test suite for Azure Blob Storage integration
pkg/crd/crds/platform-storage.schema.generated.yaml	Generated CRD schema for Azure backend
go.mod, go.sum	Adds Azure SDK dependencies
docs/	Updates documentation with Azure storage options

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pkg/apis/platform/v1beta1/storage_spec_backend_abs.go

pkg/crd/crds/platform-storage.schema.generated.yaml

pkg/util/refs.go

integrations/storage/v2/shared/abs/write.go

pkg/apis/platform/v1beta1/storage_spec_backend_abs.go

integrations/storage/v2/object.go

Copilot · 2025-12-17T12:06:10Z

pkg/util/azure/provider.go

+	return "", errors.New("no client id found")
+}
+
+func (p ProviderSecret) GetClientSecret() (string, error) {
+	if f := p.ClientSecretFile; f != "" {
+		data, err := os.ReadFile(f)
+		if err != nil {
+			return "", err
+		}
+
+		return string(data), nil
+	}
+
+	if f := p.ClientSecret; f != "" {
+		return f, nil
+	}
+
+	return "", errors.New("no client secret found")


The error messages "no client id found" and "no client secret found" should be capitalized for consistency with Go error message conventions. They should be "no client ID found" and "no client secret found" (with "ID" in capitals).

pkg/util/azure/provider.go

pkg/apis/platform/v1beta1/storage_spec_backend_abs.go

pkg/apis/platform/v1beta1/storage_spec_backend.go

Copilot

Pull request overview

Copilot reviewed 32 out of 33 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-17T14:45:11Z

pkg/integrations/sidecar/integration.storage.v2.go

+				Name:  "INTEGRATION_STORAGE_V2_AZURE_BLOB_STORAGE_ACCOUNT_NAME",
+				Value: azureBlobStorage.GetAccountName(),
+			},
+			core.EnvVar{


Duplicate environment variable definition detected. The INTEGRATION_STORAGE_V2_AZURE_BLOB_STORAGE_ACCOUNT_NAME environment variable is set twice with the same value on lines 177 and 185. Remove one of these duplicate entries.

Suggested change

Name: "INTEGRATION_STORAGE_V2_AZURE_BLOB_STORAGE_ACCOUNT_NAME",

Value: azureBlobStorage.GetAccountName(),

},

core.EnvVar{

Copilot · 2025-12-17T14:45:12Z

docs/platform/storage/azure_blob_storage.md

+      bucketPath: <Bucket Path>
+      credentialsSecret:
+        name: credentials
+      tenantID: gcr-for-testing


The example tenantID value "gcr-for-testing" appears to be a copy-paste error from GCS documentation. This should be replaced with a proper placeholder like "" that accurately reflects Azure's tenant ID format (typically a GUID).

Suggested change

tenantID: gcr-for-testing

tenantID: <Azure Tenant ID>

Copilot

Pull request overview

Copilot reviewed 32 out of 33 changed files in this pull request and generated 11 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pkg/apis/platform/v1beta1/storage_spec_backend_abs.go

pkg/integrations/storage_v2.go

docs/platform/storage/azure_blob_storage.md

docs/cli/arangodb_operator_integration.md

pkg/util/tests/azure.go

Copilot · 2025-12-17T19:36:42Z

pkg/apis/platform/v1beta1/storage_spec_backend_abs.go

+
+	// BucketPath specifies the Prefix within the bucket
+	// +doc/default:
+	BucketPrefix *string `json:"bucketPath,omitempty"`


Inconsistent field naming: BucketPrefix is stored with JSON tag "bucketPath" (line 50) but the field is named BucketPrefix. This creates confusion between the API field name and the internal field name. Consider either renaming the struct field to BucketPath or changing the JSON tag to "bucketPrefix" for consistency.

Copilot · 2025-12-17T19:36:42Z

docs/platform/storage/azure_blob_storage.md

+
+## Azure Credentials
+
+Client ID & Secret with access to the storage container and accounts needs to be saved in the secret.


Grammar issue: "accounts needs to be saved" should be "accounts need to be saved" (plural subject requires plural verb).

Suggested change

Client ID & Secret with access to the storage container and accounts needs to be saved in the secret.

Client ID & Secret with access to the storage container and accounts need to be saved in the secret.

Copilot · 2025-12-17T19:36:43Z

docs/cli/arangodb_operator_integration.md

+      --integration.shutdown.v1.external                                                    Defines if External access to service shutdown.v1 is enabled (Env: INTEGRATION_SHUTDOWN_V1_EXTERNAL)
+      --integration.shutdown.v1.internal                                                    Defines if Internal access to service shutdown.v1 is enabled (Env: INTEGRATION_SHUTDOWN_V1_INTERNAL) (default true)
+      --integration.storage.v2                                                              StorageBucket V2 Integration (Env: INTEGRATION_STORAGE_V2)
+      --integration.storage.v2.azure-blob-storage.account-name string                       AzureBlobStorage Account ID (Env: INTEGRATION_STORAGE_V2_AZURE_BLOB_STORAGE_ACCOUNT_NAME)


The flag description "AzureBlobStorage Account ID" is incorrect. This parameter refers to the Azure Storage Account Name, not an Account ID. The description should be "Azure Storage Account Name" for accuracy.

Suggested change

--integration.storage.v2.azure-blob-storage.account-name string AzureBlobStorage Account ID (Env: INTEGRATION_STORAGE_V2_AZURE_BLOB_STORAGE_ACCOUNT_NAME)

--integration.storage.v2.azure-blob-storage.account-name string Azure Storage Account Name (Env: INTEGRATION_STORAGE_V2_AZURE_BLOB_STORAGE_ACCOUNT_NAME)

Copilot · 2025-12-17T19:36:43Z

docs/api/ArangoPlatformStorage.V1Beta1.md

+### .spec.backend.azureBlobStorage.bucketName
+
+Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.3.3/pkg/apis/platform/v1beta1/storage_spec_backend_abs.go#L46)</sup>
+
+This field is **required**
+
+BucketName specifies the name of the bucket
+
+***
+
+### .spec.backend.azureBlobStorage.bucketPath
+
+Type: `string` <sup>[\[ref\]](https://github.com/arangodb/kube-arangodb/blob/1.3.3/pkg/apis/platform/v1beta1/storage_spec_backend_abs.go#L50)</sup>
+
+BucketPath specifies the Prefix within the bucket


Azure Blob Storage uses "container" terminology, not "bucket". The field documentation for bucketName and bucketPath should reference "container" instead to align with Azure's native terminology.

Copilot · 2025-12-17T19:36:43Z

integrations/storage/v2/shared/abs/io_test.go

+	"github.com/arangodb/kube-arangodb/pkg/util/tests"
+)
+
+func Test(t *testing.T) {


The test function name "Test" is too generic and does not follow Go testing conventions. Test function names should be descriptive and start with "Test" followed by a meaningful name (e.g., "TestAzureBlobStorageOperations" or "TestBasicIOOperations"). This makes it clearer what the test is validating and improves test organization.

Suggested change

func Test(t *testing.T) {

func TestAzureBlobStorageBasicIO(t *testing.T) {

[Feature] [Platform] Azure Storage Integration

04ac038

cla-bot bot added the cla-signed label Dec 17, 2025

ajanikow requested a review from Copilot December 17, 2025 11:52

Copilot started reviewing on behalf of ajanikow December 17, 2025 11:53 View session

Copilot AI reviewed Dec 17, 2025

View reviewed changes

ajanikow added 5 commits December 17, 2025 12:16

Add docs

0dc38b6

Add docs

4837c84

Add docs

e7c8e0e

Add docs

a582f05

Add docs

1eb16c6

ajanikow requested a review from Copilot December 17, 2025 14:34

Copilot started reviewing on behalf of ajanikow December 17, 2025 14:35 View session

djmeuleman approved these changes Dec 17, 2025

View reviewed changes

Copilot AI reviewed Dec 17, 2025

View reviewed changes

Add docs

076e8c2

ajanikow requested a review from Copilot December 17, 2025 19:24

Copilot started reviewing on behalf of ajanikow December 17, 2025 19:24 View session

Copilot AI reviewed Dec 17, 2025

View reviewed changes

Add docs

eed3f32

ajanikow merged commit 00289c4 into master Dec 17, 2025
3 checks passed

ajanikow deleted the feature/platform/azure_storage branch December 17, 2025 21:47


		## Azure Credentials

		Client ID & Secret with access to the storage container and accounts needs to be saved in the secret.

	--integration.storage.v2.azure-blob-storage.account-name string AzureBlobStorage Account ID (Env: INTEGRATION_STORAGE_V2_AZURE_BLOB_STORAGE_ACCOUNT_NAME)
	--integration.storage.v2.azure-blob-storage.account-name string Azure Storage Account Name (Env: INTEGRATION_STORAGE_V2_AZURE_BLOB_STORAGE_ACCOUNT_NAME)

	func Test(t *testing.T) {
	func TestAzureBlobStorageBasicIO(t *testing.T) {

[Feature] [Platform] Azure Storage Integration #2004

[Feature] [Platform] Azure Storage Integration #2004

Uh oh!

Conversation

ajanikow commented Dec 17, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants