Skip to content

properly handle edge cases on page/tab URLs #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wesinator wants to merge 10 commits into
base: master
Choose a base branch
from
Open

properly handle edge cases on page/tab URLs #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8347cb3
properly open urls from firefox reader mode page
wesinator Jun 8, 2021
fd4b2dd
fix syntax, styling
wesinator Jul 3, 2021
76ca53c
open about:reader links correctly from popup
wesinator Jul 3, 2021
18f57f6
semicolon
wesinator Jul 3, 2021
65a0c90
not applicable in background / contextmenu
wesinator Jan 21, 2023
0fd8a3d
fix code
wesinator Jan 21, 2023
7a964cf
handle all page url 'edge cases'
wesinator Jun 8, 2025
aeaff71
common style - single quotes
wesinator Jun 8, 2025
ee42dcc
block fmt
wesinator Jun 8, 2025
7451d41
ignore about: chrome urls
wesinator Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 23 additions & 19 deletions background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,32 +70,36 @@ chrome.contextMenus.onClicked.addListener(function(info, tab) {
let id = info.menuItemId;
let url = null;
if (id.endsWith('-page')) {
url = info.pageUrl;
url = processPageUrlEdgeCases(info.pageUrl);
} else if (id.endsWith('-link')) {
url = info.linkUrl;
}

if (id.startsWith('resurrect-google-')) {
goToUrl(genGoogleUrl(url), openIn, tab.id);
} else if (id.startsWith('resurrect-googletext-')) {
goToUrl(genGoogleTextUrl(url), openIn, tab.id);
} else if (id.startsWith('resurrect-archive-')) {
goToUrl(genIaUrl(url), openIn, tab.id);
} else if (id.startsWith('resurrect-archivelist-')) {
goToUrl(genIaListUrl(url), openIn, tab.id);
} else if (id.startsWith('resurrect-archiveis-')) {
goToUrl(genArchiveIsUrl(url), openIn, tab.id);
} else if (id.startsWith('resurrect-webcitation-')) {
goToUrl(genWebCiteUrl(url), openIn, tab.id);
} else if (id.startsWith('resurrect-mementoweb-')) {
goToUrl(genMementoUrl(url), openIn, tab.id);
} else if (id.startsWith('resurrect-current-tab-')) {
if (url != null) {
if (id.startsWith('resurrect-google-')) {
goToUrl(genGoogleUrl(url), openIn, tab.id);
} else if (id.startsWith('resurrect-googletext-')) {
goToUrl(genGoogleTextUrl(url), openIn, tab.id);
} else if (id.startsWith('resurrect-archive-')) {
goToUrl(genIaUrl(url), openIn, tab.id);
} else if (id.startsWith('resurrect-archivelist-')) {
goToUrl(genIaListUrl(url), openIn, tab.id);
} else if (id.startsWith('resurrect-archiveis-')) {
goToUrl(genArchiveIsUrl(url), openIn, tab.id);
} else if (id.startsWith('resurrect-webcitation-')) {
goToUrl(genWebCiteUrl(url), openIn, tab.id);
} else if (id.startsWith('resurrect-mementoweb-')) {
goToUrl(genMementoUrl(url), openIn, tab.id);
}
}

if (id.startsWith('resurrect-current-tab-')) {
setOpenIn(openInEnum.CURRENT_TAB);
} else if (id.startsWith('resurrect-new-tab-')) {
setOpenIn(openInEnum.NEW_TAB);
setOpenIn(openInEnum.NEW_TAB);
} else if (id.startsWith('resurrect-bg-tab-')) {
setOpenIn(openInEnum.NEW_BGTAB);
setOpenIn(openInEnum.NEW_BGTAB);
} else if (id.startsWith('resurrect-new-window-')) {
setOpenIn(openInEnum.NEW_WINDOW);
setOpenIn(openInEnum.NEW_WINDOW);
}
});
14 changes: 14 additions & 0 deletions common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,20 @@ function genMementoUrl(url) {
}


/* process edge cases in the page URL
* file:// scheme pages and FF reader mode
*/
function processPageUrlEdgeCases(url) {
if (url.startsWith('about:reader?url=')) {
return decodeURIComponent(url.replace('about:reader?url=', ''));
}
else if (url.startsWith('file:') || url.startsWith('about:')) {
return null
}
return url;
}


function setOpenIn(where) {
openIn = where;
chrome.storage.local.set({openIn: openIn}, logLastError);
Expand Down
13 changes: 10 additions & 3 deletions popup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,16 @@ function resurrect(gen) {
return function() {
chrome.tabs.query({active: true, currentWindow: true}, tabObj => {
logLastError();
let url = gen(tabObj[0].url);
console.info('Resurrecting via URL', url);
goToUrl(url, openIn, tabObj[0].id);

var url = processPageUrlEdgeCases(tabObj[0].url);

if (url != null)
{
let archiveUrl = gen(url);
console.info('Resurrecting via URL', archiveUrl);
goToUrl(archiveUrl, openIn, tabObj[0].id);
}

window.close();
});
}
Expand Down