src: Fix builds with musl (instead of glibc) on Linux#104
Merged
aras-p merged 1 commit intoaras-p:mainfrom Mar 21, 2025
Merged
Conversation
As 'ftello64' is a glibc-only extension, the build fails when using musl. Here, the plain 'ftello' is sufficient for 64-bit support. Fixes aras-p#103
moha-gh
commented
Mar 19, 2025
| #ifdef _MSC_VER | ||
| #define ftello64 _ftelli64 | ||
| #elif defined(__APPLE__) || defined(__FreeBSD__) | ||
| #elif defined(__APPLE__) || defined(__FreeBSD__) || (defined(__linux__) && !defined(__GLIBC__)) |
Contributor
Author
There was a problem hiding this comment.
It might be advisable to move this check somewhere else (like a dedicated header), as right now ftello64() is used not only in BuildEvents.cpp, but also in main.cpp. At the latter place, compilation only succeeds since BuildEvents.h gets included (which is a kind of a hidden dependency).
Owner
There was a problem hiding this comment.
Yeah it is a bit of a mess, I'll try to remember to do something about it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As 'ftello64' is a glibc-only extension, the build fails when using musl. Here,
the plain 'ftello' is sufficient for 64-bit support.
Fixes #103