fix: Update model_used reference after current_model_used changes#521
Open
hassan11196 wants to merge 1 commit intoarchi-physics:mainfrom
Open
fix: Update model_used reference after current_model_used changes#521hassan11196 wants to merge 1 commit intoarchi-physics:mainfrom
hassan11196 wants to merge 1 commit intoarchi-physics:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a broken model_used reference in the chat API response payload so get_chat_response continues to work after current_model_used moved to the ChatWrapper.
Changes:
- Update
get_chat_responseto readmodel_usedfromself.chat.current_model_usedinstead ofself.current_model_used.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Hi @hassan11196 , Recently PR #524 was merged to fix thread safe parameters (current_model_used). With these changes, is this PR still relevant? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
small bugfix to keep
get_chat_responsefunctional