fix: consider the update-cleanup-in-progress cloudformation state as an in-progress state #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an in-progress state
macdonst
approved these changes
Dec 15, 2025
ryanbethel
approved these changes
Dec 15, 2025
Contributor
ryanbethel
left a comment
ryanbethel
left a comment
There was a problem hiding this comment.
I think this is correct. Maybe should still have Ryan or Brian review it, but I think this is good to go and I don't think it will cause any problems.
Member
|
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you build on top of
arc deploy, you may get inconsistent results when updating a stack and removing resources. This is because AWS CloudFormation treats removal of resources as a separate CloudFormation Stack state, and executes removal of resources in a 'final' pass after any new or updated resources have been updated. Currently,arc deployassumes that if a CFN Stack is in an update-complete-cleanup-in-progress state, that the Stack update is complete.This change moves the update-complete-cleanup-in-progress state from the internal arc 'complete' states array and into the internal arc 'in progress' states array, addressing the issue.
A similar change should be considered for
arc destroy.