Fix config files missing from PyPI package#94
Merged
Conversation
config.schema.json and config.template.json were not being installed when users pip install archlens, causing FileNotFoundError on any CLI command. Move them into the src/ package directory and use package_data instead of data_files. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Narrow package_data from *.json to specific files - Fix README.md path to ../../README.md (lives at repo root) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config.schema.jsonandconfig.template.jsonwere not included in the installed package, causingFileNotFoundErroron any CLI command when installed viapip install archlenssrc/package directory so they get packaged correctlydata_fileswithpackage_datainsetup.pyTest plan
pip installfrom built wheel in a fresh venvarchlens renderworks withoutFileNotFoundErrorarchlens initcreates config from template🤖 Generated with Claude Code