[4.x] Make URL::temporarySignedRoute() respect the bypass parameter#1438
Merged
[4.x] Make URL::temporarySignedRoute() respect the bypass parameter#1438
URL::temporarySignedRoute() respect the bypass parameter#1438Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1438 +/- ##
============================================
+ Coverage 85.92% 86.08% +0.16%
- Complexity 1147 1148 +1
============================================
Files 184 184
Lines 3360 3363 +3
============================================
+ Hits 2887 2895 +8
+ Misses 473 468 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes tenant-context URL generation for URL::temporarySignedRoute() when UrlGeneratorBootstrapper is enabled, ensuring the bypass parameter is honored the same way it is for route().
Changes:
- Re-add the bypass parameter after
prepareRouteInputs()inTenancyUrlGenerator::temporarySignedRoute()so the internalroute()call can properly bypass tenancy route-name prefixing/parameter injection. - Add regression tests covering
temporarySignedRoute()route-name auto-prefixing and bypass behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Overrides/TenancyUrlGenerator.php |
Preserves the bypass flag for the internal route() call made by parent::temporarySignedRoute(). |
tests/Bootstrappers/UrlGeneratorBootstrapperTest.php |
Adds coverage to prevent regressions in signed URL generation under tenant context, including bypass behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
URL::temporarySignedRoute()in tenant context withUrlGeneratorBootstrapperenabled doesn't work the same asroute(). The bypass parameter doesn't actually bypass the route name prefixing.route()is called in theparent::temporarySignedRoute()call, and because the bypass parameter is removed before callingparent::temporarySignedRoute(), the underlyingroute()call doesn't get the bypass parameter and it ends up attempting to generate URL for a route with the name prefixed with 'tenant.'.This PR adds the bypass parameter back after
prepareRouteInputs(), so thatparent::temporarySignedRoute()receives it, and the underlyingroute()call respects it. Also added basic tests for theURL::temporarySignedRoute()behavior (the new bypass parameter test works as a regression test).