Fix resume not detecting existing submissions on disk#80
Merged
Conversation
Two bugs fixed: 1. Resume only checked checkpoint file, missing submissions created before checkpointing was added. Now checks submission_exists(). 2. Checkpoint path incorrectly added config name twice (save_submission_dir already includes config per convention).
ericc59
force-pushed
the
fix/resume-existing-submissions
branch
from
7d0e29c to
60084d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bugs fixed:
submission_exists().save_submission_diralready includes config per convention).Test plan