feat: reject the consent request when the user denies access#183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The consent screen has always rendered a Deny access button, but submitting it accepted the request anyway. Denying now calls Hydra's rejectOAuth2ConsentRequest with access_denied, and the app follows Hydra's real error redirect back to the client. The two submit buttons get distinct names so the controller knows which was clicked, the reject path mirrors the accept path's record/mapper shape, and a new Playwright test drives the full story — login, deny, and the browser landing on the client callback with error=access_denied and no code. Checks off "Allow rejecting on consent screen" from the README task list.
🤖 Generated with Claude Code