chore: fix stale README run instructions and rename the container variable#184
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local-run instructions referenced a docker-compose.yml deleted when the tests moved to testcontainers-ory-hydra, and pulled oryd/hydra:v2.0.2. They now use a single docker run mirroring the library's setup (verified end to end: health check plus client creation via docker exec), and the client walkthrough's two broken variable references are fixed. The functional-test description now matches the shared-container, unique-client-per-test design, the empty placeholder headings are removed, and the test's dockerComposeEnvironment variable is renamed to oryHydraContainer. A handful of typos fixed along the way.
🤖 Generated with Claude Code