feat: support remember-me on login and fix the login skip redirect#185
Merged
Conversation
ardetrick
force-pushed
the
feat/login-remember
branch
from
c40b2ef to
1f238ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a remember-me checkbox to the login screen (unchecked by default) and passes it through to acceptOAuth2LoginRequest, so Hydra establishes a durable login session and sends skip=true on repeat flows. Exercising that previously-unreachable skip path exposed a bug: it redirected back to the original authorization URL, which would replay the request and loop; it now follows the accept response's redirect_to. The login accept moves to the same record/mapper shape as the consent accept. A new Playwright test logs in with remember (consent-remember unchecked), runs the flow again, and asserts the browser lands on consent without the login screen — isolating the login skip. Groundwork for a logout flow, which needs a durable session to terminate.
🤖 Generated with Claude Code