Skip to content

Update attachInterrupt.adoc#832

Open
krzky wants to merge 1 commit into
arduino:masterfrom
krzky:patch-1
Open

Update attachInterrupt.adoc#832
krzky wants to merge 1 commit into
arduino:masterfrom
krzky:patch-1

Conversation

@krzky

@krzky krzky commented May 27, 2021

Copy link
Copy Markdown

more easy to find other

more easy to find other
@CLAassistant

CLAassistant commented May 27, 2021

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

=== See also

[role="language"]
* #LANGUAGE# link:../../external-interrupts/detachinterrupt[detachInterrupts()]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* #LANGUAGE# link:../../external-interrupts/detachinterrupt[detachInterrupts()]
* #LANGUAGE# link:../../external-interrupts/detachinterrupt[detachInterrupt()]

Correct function name.

Comment on lines 152 to +153
--

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--
--

Use formatting style established by the reference sample:

Let's leave this part as it was because it is unrelated to the proposal and this is how the reference sample is formatted:

https://raw.githubusercontent.com/arduino/reference-en/master/AsciiDoc_sample/Reference_Terms/AsciiDoc_Template-Single_Entity.adoc

@per1234 per1234 added the bug label May 8, 2022
@per1234

per1234 commented Jun 1, 2022

Copy link
Copy Markdown
Collaborator

Hi @krzky. I wanted to check back in with you. If you will update the pull request according to the instructions I provided above I will be happy to merge this valuable enhancement.

@per1234 per1234 self-assigned this Aug 13, 2022
@per1234 per1234 added the on hold The PR should not be merged at this time label Aug 13, 2022
@per1234 per1234 removed their assignment Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug on hold The PR should not be merged at this time

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants