fix: address unresolved review feedback from PRs #77 and #82

[arek-e]

Summary

Addresses 6 unresolved CodeRabbit review comments that were never fixed before merge:

Proxy audit logging (#77)

• Blocked-request logs missing fields — added statusCode: 403, durationMs, credentialsInjected: false, protocol for schema consistency with forwarded-request logs
• Upstream-failure logs missing statusCode — added statusCode: 502
• httpsPort log condition wrong — changed caCert ? to caCert && caKey ? so log accurately reflects whether HTTPS actually started

Workspace domain (#82)

• workspace field silently dropped — added to CP StoredDaemon interface, in-memory store create(), SQLite store create()/update()/rowToStoredDaemon(), and DB schema
• UpdateWorkspaceRequestSchema accepts all-undefined — changed .refine() from Object.keys(data).length > 0 to Object.values(data).some(v => v !== undefined)
• tsconfig.json has "types": [] — removed, violates repo convention (types from root @types/bun)

Not fixed (CodeRabbit was wrong)

• @paws/logger: "workspace:*" — CodeRabbit suggested catalog: but @paws/logger is a workspace package, not an npm dep. workspace:* is correct.

Test plan

• All 31 turbo tasks pass (183 control plane tests)
• Typecheck passes
• Verify daemon creation with workspace field persists in SQLite

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Added workspace support for daemon management and storage.

• Bug Fixes

  • Improved validation logic for workspace update requests to ensure at least one field is provided.
  • Enhanced proxy logging with additional diagnostic information for blocked domains and connection failures.
  • Fixed HTTPS port reporting in startup logs to accurately reflect server configuration.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

Schema and storage layer enhancements adding optional workspace field to daemon persistence across both in-memory and SQLite implementations. Updated workspace request validation to check for defined values rather than non-empty object keys. Enhanced proxy logging with structured fields and corrected HTTPS port reporting. Simplified workspace package configuration.

Changes

Cohort / File(s)	Summary
Daemon Storage & Schema apps/control-plane/src/db/schema.ts, apps/control-plane/src/store/daemons.ts	Added nullable workspace column to daemons table; propagated optional workspace?: string field through StoredDaemon interface and both in-memory and SQLite store implementations with proper null/undefined normalization and selective update handling.
Workspace Validation packages/domains/workspace/src/types.ts	Fixed UpdateWorkspaceRequestSchema refinement to validate Object.values().some(v !== undefined) instead of checking only key count, ensuring at least one field has a defined value.
Workspace Configuration packages/domains/workspace/tsconfig.json	Removed unused empty compilerOptions.types array from TypeScript configuration.
Proxy Server Logging packages/proxy/src/server.ts	Enhanced structured logging for domain-blocked and upstream-failure scenarios with statusCode, durationMs, credentialsInjected, and protocol fields; corrected HTTPS port reporting to only log when both caCert and caKey are present.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• proxy: add structured JSON audit logging #77: Extends structured audit logging in proxy server with additional lifecycle and connection tracking fields alongside these logging enhancements.
• feat(workspace): workspace domain — schema, store, routes, daemon linking #82: Directly related—also adds and propagates the optional workspace field through daemon storage schemas and implementations.

Poem

🐰 A workspace hops into the store,
Where daemons now track what's before,
Logs shine bright with structured care,
Validation checks with purpose fair,
Configuration trimmed, clean and tight,
Schema changes—everything right! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main purpose: addressing unresolved review feedback from two previous PRs.
Description check	✅ Passed	The description is comprehensive, covering all required sections: detailed explanations of what was changed and why, checklist items progress, and test plan verification status.
Docstring Coverage	✅ Passed	Docstring coverage is 80.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/unresolved-review-feedback

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cloudflare-workers-and-pages]

Deploying getpaws with    Cloudflare Pages

Latest commit:	86fecf2
Status:	✅  Deploy successful!
Preview URL:	https://7d86aec0.getpaws-6m4.pages.dev
Branch Preview URL:	https://fix-unresolved-review-feedba.getpaws-6m4.pages.dev

View logs