[ADH-9238] Support engine profiles blacklist - #30
Open
tigrulya-exe wants to merge 2 commits into
Open
Conversation
werzerbb
reviewed
Aug 11, 2026
| user: String): Boolean = { | ||
| if (profilesBlacklist.contains(profile)) { | ||
| warn(s"User '$user' is not allowed to implicitly use the engine profile '$profile'. " + | ||
| "Continuing without applying any engine profile.") |
Collaborator
There was a problem hiding this comment.
Minor issue: this warning ("Continuing without applying any engine profile") is only true for the last call, allowedImplicitly() is called twice. Next profile can be selected.
It's better to split this method with different logging.
Member
Author
There was a problem hiding this comment.
Nice catch! Fixed logging
Collaborator
There was a problem hiding this comment.
Seems you forgot to change KyuubiConf.scala, test failed:
https://github.com/arenadata/kyuubi/actions/runs/31653593169/job/94303001464#step:8:6509
Line 197 is not expected. The file (/home/runner/work/kyuubi/kyuubi/docs/configuration/settings.md) is out of date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added engine profiles blacklist support. It can be configured by the following option:
___(user|group)___.kyuubi.engine.profiles.blacklist=profile1,profile2