Skip to content

deleted commented lines #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
robfairh wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

deleted commented lines #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions temoa-uiuc/Snakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ DBS = ["UIUC_2050_cost"]
SCENARIOS = ["costScenario"]
FOLDER = ["UIUC_2050_cost_costScenario_model"]

@samgdotson samgdotson Feb 25, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# uncomment these lines to run the land minimization scenario.
# DBS = ["UIUC_2050_land"]
# SCENARIOS = ["landScenario"]
# FOLDER = ["UIUC_2050_land_landScenario_model"]

@samgdotson samgdotson Feb 25, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment explaining the purpose of those lines.

At the moment, we are making changes to one scenario at a time. Not a good idea to delete them right now.

Instead, we should change the # All Scenarios block, because none of those will be a part of the final analysis.
If we must delete comments, then remove the All Scenarios block.

@katyhuff katyhuff Feb 25, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely snakemake has a more graceful way to do this? (that is, more graceful than commenting and uncommenting depending on the moment... )

@samgdotson samgdotson Feb 25, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is the way to do it, based on the way I've written the rules.
You can limit the rules that are executed with the --until flag, but the current rules will run every scenario listed in the DB, SCENARIO, and FOLDER variables.

The only alternative I can think of is to write one rule for each scenario, but then the snakefile is repeating code. This was the approach I took in the snakefile for cairo, but each scenario actually has a different command line argument and snakemake doesn't like it when the wildcards aren't the same.

# DBS = ["UIUC_2050_land"]
# SCENARIOS = ["landScenario"]
# FOLDER = ["UIUC_2050_land_landScenario_model"]

SECTORS = ["ind", "elc", "vcl", "all"]
EMISSIONS = ['co2eq', 'ewaste', 'spent-fuel']

Expand Down