Define escrow trade types - #183
Open
DeFex-lab wants to merge 15 commits into
Open
Conversation
|
@DeFex-lab Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
dark-sarge
requested changes
Aug 28, 2026
dark-sarge
left a comment
Contributor
There was a problem hiding this comment.
please resolve all conflicts
Contributor
Author
|
Apologies for the late response and for the merge conflicts. I'm working on resolving them now and will update the PR once they're fixed. Thanks for your patience! |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
dark-sarge
self-requested a review
August 31, 2026 22:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the failing CI workflows for PR #183 by aligning the GitHub Actions jobs with the pnpm workspace setup, repairing frontend lint/build blockers, and making the Soroban contract checks run on a host target for testutils.
Related Issue
Closes #150
Changes
pnpm-lock.yamlfor cache keys.x86_64-unknown-linux-gnu, avoiding the workspace wasm default for testutils-based checks.next lintto fail in CI.maininto the PR branch and fixed the new Linux-only typecheck failures in the merged tree.Verification Results
cargo fmt --all -- --check- passedcargo check --all-features --target x86_64-pc-windows-msvc- passedcargo clippy --all-targets --all-features --target x86_64-pc-windows-msvc -- -D warnings- passedcargo test --all-features --target x86_64-pc-windows-msvc- passedpnpm install --frozen-lockfile- passedpnpm tsc --noEmitinserver- passedpnpm exec jest --runInBand --forceExit --json --outputFile=test-results.json --passWithNoTestsinserver- passed, 17 suites / 119 testspnpm lintinserver- passedpnpm buildinserver- passedpnpm lintinfrontend- passed with existing hook dependency warningspnpm tsc --noEmitinfrontend- passedpnpm exec jest --coverageinfrontend- passed, 9 suites / 71 testsNEXT_PUBLIC_API_URL=http://localhost:3001 pnpm buildinfrontend- passedgit diff --check- passedDocker/Trivy image scan was not run locally because Docker is not installed or not available on PATH in this environment.
Acceptance Criteria