Skip to content

fix : découpe et amincissement — deux lectures de mémoire indéfinie qui rendaient roofer non déterministe #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guhur merged 2 commits into from
Oct 4, 2026
Merged

fix : découpe et amincissement — deux lectures de mémoire indéfinie qui rendaient roofer non déterministe #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8281b14
fix(cropper): initialise the loop index that merges buffer ground points
guhur Oct 4, 2026
2bc98e2
fix(thinning): skip points one past the count raster instead of readi…
guhur Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/extra/io/StreamCropper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ namespace roofer::io {

// merge buffer ground points into regular point_clouds now that the
// proper counts have been established
for (size_t poly_i; poly_i < polygons.size(); poly_i++) {
for (size_t poly_i = 0; poly_i < polygons.size(); poly_i++) {
auto& point_cloud = point_clouds.at(poly_i);
auto classification =
point_cloud.attributes.get_if<int>("classification");
Expand Down
2 changes: 1 addition & 1 deletion src/extra/misc/PointcloudRasteriser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ namespace roofer::misc {
auto& p = pointcloud[pi];
auto& c = (*classification)[pi];
auto i = getLinearCoord(cnt_image, p[0], p[1]);
if (i < 0 || i > cnt_image.array.size()) continue;
if (i < 0 || i >= cnt_image.array.size()) continue;

// check if we have too many points in this cell
if (cnt_image.array[i] > max_cnt_per_cell) {
Expand Down