Reuse compatible iOS audio session in TTSKit playback#464
Open
shura-v wants to merge 3 commits into
Open
Conversation
shura-v
force-pushed
the
reuse-audio-session
branch
from
1fa83db to
38ea263
Compare
Contributor
|
Hi @shura-v , thank you for the contribution. Please rebase your PR to pickup latest CI changes which should resolve the failing tests. We'll add these to next release once CI builds pass. |
shura-v
force-pushed
the
reuse-audio-session
branch
from
7201e0b to
2237657
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
preserveExistingAudioSessionoption toTTSKitConfigfor iOS playback.By default, behavior is unchanged and
TTSKitstill configuresAVAudioSessionfor.playbackwhen starting playback. WhenpreserveExistingAudioSessionis enabled,TTSKitonly activates the existing session and leaves its category, mode, and options untouched.Why
Some apps already own an active
.playAndRecordsession when starting TTS playback. Attempting to switch that shared session to.playbackcan fail at runtime, so this opt-in allows host apps to keep their existing audio session configuration.Testing
swift build --target TTSKit