Remove deprecated argument from IonicAudioModule.forRoot in demo#99
Open
lujakob wants to merge 2 commits intoarielfaur:2.0from
Open
Remove deprecated argument from IonicAudioModule.forRoot in demo#99lujakob wants to merge 2 commits intoarielfaur:2.0from
lujakob wants to merge 2 commits intoarielfaur:2.0from
Conversation
|
@lujakob can you explain me why this is also included do we need it? and second thing AudioProvider in import? |
Author
|
export function myCustomAudioProviderFactory is not needed but added by the author as an example for adding a custom AudioProvider. And as it's a demo, I didn't want to remove it (I wouldn't want to take the authority, I just fixed an error). |
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After running the demo app the following Typescript error is thrown:
Argument of type '{ provide: typeof AudioProvider; useFactory: any; }' is not assignable to parameter of type 'AudioProvider'. In the module definition the argument is of type AudioProvider, so I guess there have been changes and this is a leftover. I removed the arguments for the demo app.module definition to use the argument defaults instead (as it is seen in the installed npm package)