fix(ops): don't cache degraded inventory + run vitest in CI (P2)#212
Merged
Conversation
Holistic review, ops hardening. - inventory_tools._load_inventory cached whatever it produced for 300s, INCLUDING the single-fake-home sample fallback — so a transient Firestore/JSON outage froze a near-empty/fake catalog in front of customers for 5 minutes. Cache only healthy results; leave the sample fallback uncached so the next request re-tries the real sources and recovers immediately. + regression tests. - CI built the frontend but never ran its 50 vitest tests, so frontend logic regressions could reach prod ungated. Add a 'Run frontend tests (vitest)' step to deploy.yml. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ops hardening from the holistic review: (1) don't cache the sample-fallback inventory (a Firestore blip no longer freezes a fake/near-empty catalog for 5 min — regression tests added); (2) CI now runs the 50 vitest frontend tests it was only building before. Backend targeted tests + ruff green; deploy.yml valid.