test(hermeticity): never let the test suite touch prod Firestore (item 7)#215
Merged
Conversation
A developer's ADC defaults to the prod project, so unmocked test writes landed in LIVE customer data (this session's full-suite runs created junk leads in prod — see memory tho-prod-ops-state). conftest now points Firestore at an absent local emulator host + a throwaway project, so any unmocked write fails fast LOCALLY instead of polluting prod. CI already has no ADC (no-op there); runtime/prod is unaffected (pytest-only). To use a real emulator, start it + set the env yourself. Verified: full suite 1113 passed locally, prod leads count unchanged (63 -> 63). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
conftest points Firestore at an absent emulator host + throwaway project so unmocked test writes fail fast locally instead of polluting prod (this session's local full-suite runs created junk leads in live data). CI no-op (no ADC there); runtime unaffected. Verified: full suite 1113 passed, prod leads 63→63.