Improve error handling for missing object tag in connect_timelapse#125
Draft
arjunrajlab wants to merge 2 commits intomasterfrom
Draft
Improve error handling for missing object tag in connect_timelapse#125arjunrajlab wants to merge 2 commits intomasterfrom
arjunrajlab wants to merge 2 commits intomasterfrom
Conversation
Check for missing/empty tags before attempting to convert to set, preventing TypeError when tags are None. Use sendError with info message and return gracefully instead of raising an exception. https://claude.ai/code/session_01GRr1rfjTWiPomHhCzy8NZG
- Replace old test that expected ValueError with three new tests - Test empty list, None, and missing key scenarios - Verify sendError is called with correct message and info - Verify worker returns early without fetching annotations https://claude.ai/code/session_01GRr1rfjTWiPomHhCzy8NZG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improved error handling in the connect_timelapse worker to gracefully handle missing or invalid object tags instead of raising exceptions. The worker now sends a user-friendly error message and returns early without proceeding with annotation processing.
Key Changes
object_tagbefore attempting to use it, with clear error messagingsendErrorcall to include aninfoparameter with actionable guidance for usersValueErrorto callingsendErrorand returning, allowing the worker to fail gracefullyNonevalue for object tagObject to connect tagkey entirelyImplementation Details
object_tagfromworkerInterfacesendErroris called with appropriate messaging and that downstream operations (likegetAnnotationsByDatasetId) are not executedhttps://claude.ai/code/session_01GRr1rfjTWiPomHhCzy8NZG