Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying wallet-bitcoin with
|
| Latest commit: |
fe6b465
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bf7f98b6.wallet-bitcoin.pages.dev |
| Branch Preview URL: | https://delegate-list.wallet-bitcoin.pages.dev |
Deploying wallet-mutinynet with
|
| Latest commit: |
fe6b465
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://70a99089.arkade-wallet.pages.dev |
| Branch Preview URL: | https://delegate-list.arkade-wallet.pages.dev |
src/screens/Init/Restore.tsx
Outdated
| .restore((conf) => | ||
| // we enforce delegates on restore | ||
| updateConfig({ ...conf, delegate: true }), | ||
| updateConfig({ ...conf, delegates: { ...conf.delegates, enabled: true } }), |
There was a problem hiding this comment.
What happens if conf.delegates.activeUrl === undefined ? We set it to enabled but it won't have the url, meaning that it will be effectively disabled.
It can lead to bug reports difficult to understand.
src/providers/config.tsx
Outdated
| aspUrl: defaultArkServer(), | ||
| currencyDisplay: CurrencyDisplay.Both, | ||
| delegate: import.meta.env.VITE_DELEGATE_ENABLED !== 'false', | ||
| delegates: getDefaultDelegatesForNetwork('bitcoin' as any), |
- Use 'bitcoin' as Network instead of 'bitcoin' as any (config.tsx) - Ensure activeUrl is set when enabling delegates on restore (Restore.tsx) Fixes concerns from @pietro909's review.
louisinger
force-pushed
the
delegate-list
branch
from
44d19f7 to
fe6b465
Compare
2 participants
No description provided.