Skip to content

Fix this package for web builds#1

Open
dickverweij wants to merge 3 commits intoarkatech-ir:masterfrom
dickverweij:master
Open

Fix this package for web builds#1
dickverweij wants to merge 3 commits intoarkatech-ir:masterfrom
dickverweij:master

Conversation

@dickverweij
Copy link
Copy Markdown

Because the file lib/src/web/open_file_safe.dart was expected (it was not renamed) this package cannot build under web.

@NZhlebinkov
Copy link
Copy Markdown

Hey, when is this planned to be merged? Would be quite useful for web too

@marinkobabic
Copy link
Copy Markdown

Please merge this pull request. In minimum please update the ffi library to the latest version.

@radiKal07
Copy link
Copy Markdown

@arkatech-ir can you merge this?

@jbryanh
Copy link
Copy Markdown

jbryanh commented Jan 4, 2024

recommend package replacement that is maintained?...or I wonder if open_file is fixed yet? @dickverweij I'm depending on your latest commit for now, no time to unwind why this package was necessary in the first place. Thanks for that.

@dickverweij
Copy link
Copy Markdown
Author

Hi @jbryanh , The only reason we used open_file_save was because it fixed the permission (removed it) REQUEST_INSTALL_PACKAGES from the manifest. Our security policies does not allow for such a permission. From that point we used open_file_save. If open_file has removed this permission (and works also for web) there is no reason to use the original package. (and abandon this package) I am not the maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants