control armbian-common: move armbian-bsp to Suggests

[tabrisnet]

This has been discussed in #25.
Specifically, we cannot pull in armbian-bsp into the rootfs. We want to install it a bit later in the armbian/build image process, and in fact that is already done [no change is needed in armbian/build].

[coderabbitai]

Walkthrough

This change modifies the debian/control file for the armbian-common package. The dependency on armbian-bsp or armbian-bsp-cli (specified as armbian-bsp|armbian-bsp-cli) has been moved from the Depends field to the Suggests field. This transitions the dependency from mandatory to optional, changing the default installation behavior while maintaining the relationship in the package metadata.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Single file modification with a straightforward dependency metadata move
• Verify the dependency identifier was correctly transferred to the Suggests field
• Confirm debian/control syntax remains valid and no unintended lines were modified
• Ensure this behavioral change aligns with the package's intended design

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: moving armbian-bsp from Depends to Suggests in the control file for armbian-common.
Description check	✅ Passed	The description is related to the changeset, explaining the rationale for moving armbian-bsp to Suggests and referencing prior discussion in issue #25.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d91080a and aa9307e.

📒 Files selected for processing (1)

• debian/control (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: tabrisnet
Repo: armbian/apa PR: 25
File: debian/control:23-23
Timestamp: 2025-12-06T21:01:15.459Z
Learning: In the armbian/apa repository's debian/control, iputils-ping is temporarily added to armbian-common's Depends as a workaround for a capability issue where /bin/ping cannot create raw sockets. The proper solution involves: (1) PR #27, (2) removing the chmod u+s workaround code from armbian/build (armbian/build#9033), and (3) adding libcap2-bin to armbian/build's debootstrap package list so that iputils-ping's postinst script can use setcap to properly configure /bin/ping. Once these pieces are complete and merged, iputils-ping should be removed from armbian-common's Depends as it will no longer be needed.

📚 Learning: 2025-12-06T21:01:15.459Z

Learnt from: tabrisnet
Repo: armbian/apa PR: 25
File: debian/control:23-23
Timestamp: 2025-12-06T21:01:15.459Z
Learning: In the armbian/apa repository's debian/control, iputils-ping is temporarily added to armbian-common's Depends as a workaround for a capability issue where /bin/ping cannot create raw sockets. The proper solution involves: (1) PR #27, (2) removing the chmod u+s workaround code from armbian/build (armbian/build#9033), and (3) adding libcap2-bin to armbian/build's debootstrap package list so that iputils-ping's postinst script can use setcap to properly configure /bin/ping. Once these pieces are complete and merged, iputils-ping should be removed from armbian-common's Depends as it will no longer be needed.

Applied to files:

• debian/control

🔇 Additional comments (1)

debian/control (1)

35-37: Demoting armbian-bsp|armbian-bsp-cli to Suggests matches the stated packaging goal

The control stanza remains syntactically correct and consistent with existing style, and moving BSP from Depends to Suggests cleanly implements the intent of keeping BSP out of the initial rootfs while still advertising the relationship.

The only thing to double‑check is behavior in non‑armbian/build flows: e.g., apt install armbian-common on an existing system (or during upgrades) will no longer pull in BSP automatically since Suggests are not installed by default. If that’s acceptable and covered by tooling/docs (as your description suggests), this change looks good to ship.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}