docs(rss): links within RSS - add BaseURL to config.toml #1732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use baseUrl="/" in config.toml add RSS template from theme
aimeeu
changed the title
aimeeu
changed the title
link108
approved these changes
Mar 8, 2023
Contributor
|
I just tested the RSS feed out and it wasn't working, but that brought me to this PR 👍 I checked out the netlify preview, but I wasn't able to confirm if the RSS feed was updated - the RSS button points to docs.armory.io instead of the netlify preview. That isn't a blocker, but maybe we have to test this in prod, unless there's a way to test it out via netlify 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
BaseURLto config.toml to see if that resolves the in the RSS feed being relative (doesn't have domain)Resolves Jira: DOC-688