Skip to content

fix(#126): Improves build time #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lordofthejars merged 2 commits into from
Oct 4, 2017
Merged

fix(#126): Improves build time #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2659c79
fix(#126): Improves build time by ignoring overlapping tests and narr…
lordofthejars Oct 2, 2017
58b8b02
fix: Deletes overlapping test
lordofthejars Oct 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...test/affected/ChangesOnDifferentModulesAffectedTestsSelectionExecutionFunctionalTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public void should_detect_changes_on_maven_modules_and_execute_test() {

// when
final TestResults actualTestResults = project
.build()
.build("config/impl-base")
.options()
.withSystemProperties("scm.range.head", "HEAD", "scm.range.tail", "HEAD~")
.configure()
Expand Down
1 change: 1 addition & 0 deletions ...esting/ftest/affected/HistoricalChangesAffectedTestsSelectionExecutionFunctionalTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import org.arquillian.smart.testing.rules.TestBed;
import org.arquillian.smart.testing.ftest.testbed.testresults.TestResult;
import org.junit.ClassRule;
import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;

Expand Down
4 changes: 2 additions & 2 deletions ...art/testing/ftest/affected/LocalChangesAffectedTestsSelectionExecutionFunctionalTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public void should_only_execute_tests_related_to_single_local_change_in_producti
.applyAsLocalChanges("Single method body modification - sysout");

// when
final TestResults actualTestResults = project.build().run();
final TestResults actualTestResults = project.build("config/impl-base").run();

// then
assertThat(actualTestResults.accumulatedPerTestClass()).containsAll(expectedTestResults).hasSameSizeAs(expectedTestResults);
Expand All @@ -58,7 +58,7 @@ public void should_only_execute_tests_related_to_multiple_local_changes_in_produ
"Inlined variable in a method");

// when
final TestResults actualTestResults = project.build().run();
final TestResults actualTestResults = project.build("config/impl-base").run();

// then
assertThat(actualTestResults.accumulatedPerTestClass()).containsAll(expectedTestResults).hasSameSizeAs(expectedTestResults);
Expand Down
62 changes: 0 additions & 62 deletions ...rt/testing/ftest/failed/HistoricalChangesFailedTestsSelectionExecutionFunctionalTest.java
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions ...n/smart/testing/ftest/failed/LocalChangesFailedTestsSelectionExecutionFunctionalTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public void should_only_execute_previously_failing_tests_when_failed_is_enabled(
project.applyAsCommits("Introduces error by changing return value");

project
.build()
.build("container/impl-base")
.options()
.ignoreBuildFailure()
.configure()
Expand All @@ -49,7 +49,7 @@ public void should_only_execute_previously_failing_tests_when_failed_is_enabled(


// when
final TestResults actualTestResults = project.build().run();
final TestResults actualTestResults = project.build("container/impl-base").run();

// then
assertThat(actualTestResults.accumulatedPerTestClass()).containsAll(expectedTestResults).hasSameSizeAs(expectedTestResults);
Expand Down
2 changes: 1 addition & 1 deletion .../smart/testing/ftest/mixed/LocalChangesMixedStrategySelectionExecutionFunctionalTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public void should_execute_all_new_tests_and_related_to_production_code_changes(
"Inlined variable in a method", "Adds new unit test");

// when
final TestResults actualTestResults = project.build().run();
final TestResults actualTestResults = project.build("config/impl-base").run();

// then
assertThat(actualTestResults.accumulatedPerTestClass()).containsAll(expectedTestResults).hasSameSizeAs(expectedTestResults);
Expand Down
4 changes: 2 additions & 2 deletions ...an/smart/testing/ftest/newtests/LocalChangesNewTestsSelectionExecutionFunctionalTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public void should_only_execute_new_tests_related_to_single_local_change() throw
.applyAsLocalChanges("Adds new unit test");

// when
final TestResults actualTestResults = project.build().run();
final TestResults actualTestResults = project.build("config/impl-base").run();

// then
assertThat(actualTestResults.accumulatedPerTestClass()).containsAll(expectedTestResults).hasSameSizeAs(expectedTestResults);
Expand All @@ -61,7 +61,7 @@ public void should_only_execute_new_tests_related_to_single_local_change_using_f
.applyAsLocalChanges("Adds new unit test");

// when
final TestResults actualTestResults = project.build().run("clean", "verify");
final TestResults actualTestResults = project.build("config/impl-base").run("clean", "verify");

// then
assertThat(actualTestResults.accumulatedPerTestClass()).containsAll(expectedTestResults).hasSameSizeAs(expectedTestResults);
Expand Down