Skip to content

chore: update dependencies#51

Merged
rjfonseca merged 1 commit into
mainfrom
chore/update-dependencies
Dec 17, 2025
Merged

chore: update dependencies#51
rjfonseca merged 1 commit into
mainfrom
chore/update-dependencies

Conversation

@rjfonseca

Copy link
Copy Markdown
Member

Updates:

  • go;
  • dependencies;
  • golangci-lint config
  • github workflows

And fixes errors raised by the linter.

Updates:
- go;
- dependencies;
- golangci-lint config
- github workflows

And fixes errors raised by the linter.
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
8.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Go toolchain to version 1.25, updates all project dependencies, modernizes the golangci-lint configuration to version 2 format, and updates GitHub Actions workflows to use newer versions. The changes address linter errors by replacing deprecated ref.Str() calls with ref.Of() throughout the test suite.

Key changes:

  • Updated Go from 1.22.7 to 1.25 and refreshed all dependencies
  • Modernized golangci-lint configuration from v1 to v2 format with restructured linter settings
  • Updated GitHub Actions to use latest stable versions (checkout@v6, setup-go@v6, golangci-lint-action@v9)

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
queryplanner_test.go Replaced deprecated ref.Str() calls with ref.Of() throughout test fixtures
go.mod Updated Go version to 1.25 and bumped all dependencies to latest versions
.golangci.yml Migrated configuration to version 2 format with reorganized linter and formatter settings
.github/workflows/golangci-lint.yml Updated actions to v6/v9 and switched to stable Go version
.github/workflows/go-test.yml Updated actions to v6 and switched to stable Go version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .golangci.yml
- dupl
- goconst
- gocyclo
- govet

Copilot AI Dec 17, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'govet' linter has been removed from the enabled list. In the new configuration format, only 'govet' remains from the original comprehensive set that included 'gosimple' and 'staticcheck'. The old configuration had 'gosimple' enabled which is missing in the new version. Consider re-enabling 'gosimple' to maintain the same level of code quality checks.

Suggested change
- govet
- govet
- gosimple

Copilot uses AI. Check for mistakes.
Comment thread .golangci.yml
- bodyclose
- dupl
- goconst
- gocyclo

Copilot AI Dec 17, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'exportloopref' linter from the original configuration has been removed. This linter checks for pointers to enclosing loop variables, which is an important check for preventing common bugs in Go. Consider re-adding it to the enabled linters list.

Suggested change
- gocyclo
- gocyclo
- exportloopref

Copilot uses AI. Check for mistakes.
Comment thread .golangci.yml
- noctx
- prealloc
- rowserrcheck
- staticcheck

Copilot AI Dec 17, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'stylecheck' linter from the original configuration has been removed. This linter was noted as 'a replacement for golint' and helps enforce style consistency. Consider re-adding it to maintain consistent code style standards.

Suggested change
- staticcheck
- staticcheck
- stylecheck

Copilot uses AI. Check for mistakes.
Comment thread .golangci.yml
Comment on lines +16 to +17
- unconvert
- unparam

Copilot AI Dec 17, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'typecheck' linter has been removed from the configuration. This linter parses and type-checks Go code like the front-end of a Go compiler, which is a fundamental check. Consider re-adding it to the enabled linters list.

Copilot uses AI. Check for mistakes.
@rjfonseca rjfonseca merged commit 8744cc4 into main Dec 17, 2025
3 of 4 checks passed
@rjfonseca rjfonseca deleted the chore/update-dependencies branch December 17, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants